Conversation
- created configuration for multiple instances of telemetry - created robust test case with dedicated TestKernel
- capture console commands telemetry - capture messenger telemetry - capture http kernel telemetry
… container - updated dependencies in website to be links from monorepo
| ->scalarNode('version') | ||
| ->info('Instrumentation scope version') | ||
| ->defaultValue('unknown') | ||
| ->end() | ||
| ->scalarNode('schema_url') | ||
| ->info('Schema URL for semantic conventions') | ||
| ->defaultNull() | ||
| ->end() | ||
| ->arrayNode('attributes') | ||
| ->info('Additional scope attributes') | ||
| ->normalizeKeys(false) | ||
| ->useAttributeAsKey('name') | ||
| ->prototype('variable')->end() | ||
| ->end() | ||
| ->end() |
There was a problem hiding this comment.
Do we need some validation over those? Like if schema is URL-like etc?
There was a problem hiding this comment.
I don't think so, all of those are being unit tested
There was a problem hiding this comment.
I get it's unit tested, which is great, but I speak about DX here :) So validation for the developer using that bundle and passing random crap 😂
There was a problem hiding this comment.
I'm not sure I get it, the whole point of those attributes is to pass random crap to APM :P
There was a problem hiding this comment.
Comments on mobiles doesn't work best ;) it was more related to schema urls or versions not attributes only ;)
| ->info('HTTP kernel request tracing configuration') | ||
| ->canBeEnabled() | ||
| ->children() | ||
| ->arrayNode('exclude_routes') |
There was a problem hiding this comment.
With routes, it's tricky to cover them well cause you sometimes want to exclude, i.e., 401/403/404, but you still want to have 200 covered
There was a problem hiding this comment.
hmm what would be the reason to exclude 404's?
There was a problem hiding this comment.
Not often, but I had cases where 404 was triggered by some bots scanning IPs and kinda doing DDoS due to the amount of data being logged in a short time frame, but the data logged there was useless, as it was completely random data.
There was a problem hiding this comment.
yea I see how this might be tempting, but it should be filtered by:
- otel collector
- apm itself
This way the whole logic and cost of filtering is moved away from a process that we are collecting telemetry from keeping the impact minimal.
I might need to even remove that regexp
| return $transportServiceId; | ||
| } | ||
|
|
||
| $endpoint = $config['endpoint'] ?? 'http://localhost:4318'; |
There was a problem hiding this comment.
I think you enforce values on the configuration level, no?
| $parts = \explode('\\', $className); | ||
|
|
||
| return \end($parts); |
There was a problem hiding this comment.
| $parts = \explode('\\', $className); | |
| return \end($parts); | |
| return \substr(\strrchr($className, '\\'), 1); |
2 participants
Resolves: #xxx
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security